trunner: add sparcv8leon3-generic-qemu target support #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
regarding the commit message: this is not a name of any TaRgEt supported by phoenix-RTOS :P |
damianloew
requested changes
Sep 18, 2024
maska989
force-pushed
the
maska989/add_Sparcv8Leon3_General_support
branch
from
8f3e1a7
to
c141281
Compare
maska989
changed the title
maska989
force-pushed
the
maska989/add_Sparcv8Leon3_General_support
branch
2 times, most recently
from
24427c5
to
b33c810
Compare
There was a problem hiding this comment.
When building with tests option
LD test_mmap
/src/phoenix-rtos-tests/devices/grlib-multi/test-grlib-multi.c:28:2: error: #error "Unsupported target"
28 | #error "Unsupported target"
| ^~~~~
/src/phoenix-rtos-tests/devices/grlib-multi/test-grlib-multi.c:31:10: fatal error: grlib-multi.h: No such file or directory
31 | #include <grlib-multi.h>
| ^~~~~~~~~~~~~~~
compilation terminated.
make: *** [../phoenix-rtos-build/Makefile.common:211: /src/_build/sparcv8leon3-generic-qemu/phoenix-rtos-tests/devices/grlib-multi/test-grlib-multi.o] Error 1
make: *** Waiting for unfinished jobs....
b33c810
to
f515cfb
Compare
You could add this to the Makefile.sparcvleon3, or come up with better solution |
maska989
force-pushed
the
maska989/add_Sparcv8Leon3_General_support
branch
2 times, most recently
from
1d3be02
to
65d206a
Compare
maska989
force-pushed
the
maska989/add_Sparcv8Leon3_General_support
branch
3 times, most recently
from
baa8005
to
2f114c5
Compare
damianloew
reviewed
Oct 2, 2024
maska989
force-pushed
the
maska989/add_Sparcv8Leon3_General_support
branch
2 times, most recently
from
1998544
to
500f476
Compare
damianloew
requested changes
Oct 11, 2024
maska989
force-pushed
the
maska989/add_Sparcv8Leon3_General_support
branch
3 times, most recently
from
78aa65c
to
8b01125
Compare
damianloew
reviewed
Oct 11, 2024
There was a problem hiding this comment.
Some notes about commit descriptions.
As it's described in our Golden Rules
- describe WHY You're doing the change in the commit message body
So you don't want to repeat what you have added in the commit message body (called also commit description). In your case the reason of adding a new target is rather obvious - we just want to support all of our available targets.
About the second commit sparcv8leon3: prevent from building test-grlib-multi on qemu target - the commit title shows perfectly what is going on in this change, you probably want to add information WHY do we need to exclude it, so a good commit description would be:
This test is not intended to build on this particular target.
8b01125
to
a007e5d
Compare
maska989
force-pushed
the
maska989/add_Sparcv8Leon3_General_support
branch
from
a007e5d
to
c0b8b5c
Compare
This test is not intended to be built on this particular target. JIRA: CI-474
maska989
force-pushed
the
maska989/add_Sparcv8Leon3_General_support
branch
from
c0b8b5c
to
3ac9225
Compare
damianloew
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: CI-474
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment
scripts: add sparcv8leon3-generic-qemu-test script phoenix-rtos-project#1168